Re: [PATCH v6 18/28] media: uapi: Allow a larger number of routes than there's room for

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Thu, Oct 05, 2023 at 01:08:25PM +0200, Hans Verkuil wrote:
> On 03/10/2023 14:08, Sakari Ailus wrote:
> > On VIDIOC_SUBDEV_[GS]_ROUTING, only return as many routes back to the user
> > as there's room. Do not consider it an error if more routes existed.
> > Simply inform the user there are more routes.
> 
> I'm not convinced by this change. Can userspace do anything useful with only
> a partially filled routes array?
> 
> Just silently allowing bad data is asking for problems, IMHO.

The idea is that the driver may return more routes than the user sets but
the user may be interested in just one route, the one it enabled. Should
the user space be required to obtain streams even if they are not of
interest?

-- 
Regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux