Hi Bingbu,
Thanks for the updated series. I've rebased my work on this series, and
ran into the following issue.
On Tue, 2023-10-24 at 19:29 +0800, bingbu.cao@xxxxxxxxx wrote:
> +static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver)
...
> + ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_MSI);
> + if (ret)
> + dev_err_probe(&dev->dev, ret, "Request msi failed");
> +
> + return ret;
> +}
pci_alloc_irq_vectors returns number of irqs, so I think it should be
something like this instead:
ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_MSI);
if (ret<0) {
dev_err_probe(&dev->dev, ret, "Request msi failed");
return ret;
}
return 0;
/Andreas
