Hi Andy, On Tue, Oct 24, 2023 at 04:04:05PM +0300, Andy Shevchenko wrote: > On Tue, Oct 24, 2023 at 07:29:21PM +0800, bingbu.cao@xxxxxxxxx wrote: > > From: Bingbu Cao <bingbu.cao@xxxxxxxxx> > > > > Add IPU6 support in Kconfig and Makefile, with this patch you can > > build the Intel IPU6 and input system modules by select the > > CONFIG_VIDEO_INTEL_IPU6 in config. > > ... > > > + depends on X86 && X86_64 > > How is that? One is a superset of the other IIUC. > > ... > > > +intel-ipu6-objs += ipu6.o \ > > += doesn't seem right. > Besides that 'objs' is for user space, in kernel we use 'y'. This is a common pattern used in other Makefiles, too... I guess ":=" would work, too. How otherwise would you do this? It'd be nice to align the object names starting after the column after "+= ". > > > + ipu6-bus.o \ > > + ipu6-dma.o \ > > + ipu6-mmu.o \ > > + ipu6-buttress.o \ > > + ipu6-cpd.o \ > > + ipu6-fw-com.o > > + > > +obj-$(CONFIG_VIDEO_INTEL_IPU6) += intel-ipu6.o > > + > > +intel-ipu6-isys-objs += ipu6-isys.o \ > > Ditto. > > > + ipu6-isys-csi2.o \ > > + ipu6-fw-isys.o \ > > + ipu6-isys-video.o \ > > + ipu6-isys-queue.o \ > > + ipu6-isys-subdev.o \ > > + ipu6-isys-mcd-phy.o \ > > + ipu6-isys-jsl-phy.o \ > > + ipu6-isys-dwc-phy.o > > + > > +obj-$(CONFIG_VIDEO_INTEL_IPU6) += intel-ipu6-isys.o > -- Regards, Sakari Ailus
