Andy, Thanks for the review. On 10/24/23 9:04 PM, Andy Shevchenko wrote: > On Tue, Oct 24, 2023 at 07:29:21PM +0800, bingbu.cao@xxxxxxxxx wrote: >> From: Bingbu Cao <bingbu.cao@xxxxxxxxx> >> >> Add IPU6 support in Kconfig and Makefile, with this patch you can >> build the Intel IPU6 and input system modules by select the >> CONFIG_VIDEO_INTEL_IPU6 in config. > > ... > >> + depends on X86 && X86_64 > > How is that? One is a superset of the other IIUC. It's trying to prevent build IPU6 with other arch such as 'UM'. # make W=1 O=build_dir ARCH=um olddefconfig ipu6-dma.c:... error: implicit declaration of function 'clflush_cache_range'; X86_64 looks like not an actual architecture. > > ... > >> +intel-ipu6-objs += ipu6.o \ > > += doesn't seem right. > Besides that 'objs' is for user space, in kernel we use 'y'. > >> + ipu6-bus.o \ >> + ipu6-dma.o \ >> + ipu6-mmu.o \ >> + ipu6-buttress.o \ >> + ipu6-cpd.o \ >> + ipu6-fw-com.o >> + >> +obj-$(CONFIG_VIDEO_INTEL_IPU6) += intel-ipu6.o >> + >> +intel-ipu6-isys-objs += ipu6-isys.o \ > > Ditto. Ack. > >> + ipu6-isys-csi2.o \ >> + ipu6-fw-isys.o \ >> + ipu6-isys-video.o \ >> + ipu6-isys-queue.o \ >> + ipu6-isys-subdev.o \ >> + ipu6-isys-mcd-phy.o \ >> + ipu6-isys-jsl-phy.o \ >> + ipu6-isys-dwc-phy.o >> + >> +obj-$(CONFIG_VIDEO_INTEL_IPU6) += intel-ipu6-isys.o > -- Best regards, Bingbu Cao
