[sailus-media-tree:metadata 6/42] drivers/staging/media/ipu3/ipu3-v4l2.c:200:1: error: control reaches end of non-void function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://linuxtv.org/sailus/media_tree.git metadata
head:   9d9606b3c96b65b0cdc5978ffa2699de5c5d6feb
commit: 664ffe0ad78d9dc70a40fbf51ad5d9aeda061d23 [6/42] media: v4l: subdev: Switch to stream-aware state functions
config: x86_64-randconfig-003-20231025 (https://download.01.org/0day-ci/archive/20231025/202310250538.rAiAP4fr-lkp@xxxxxxxxx/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231025/202310250538.rAiAP4fr-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310250538.rAiAP4fr-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   In file included from include/media/v4l2-device.h:13:0,
                    from drivers/staging/media/ipu3/ipu3.h:11,
                    from drivers/staging/media/ipu3/ipu3-v4l2.c:10:
   drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'imgu_subdev_open':
   include/media/v4l2-subdev.h:1557:9: error: implicit declaration of function '__v4l2_subdev_state_get_format___VA_OPT__'; did you mean '__v4l2_subdev_state_get_format_'? [-Werror=implicit-function-declaration]
            __v4l2_subdev_state_get_format_ ## __VA_OPT__(stream) \
            ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:39:4: note: in expansion of macro 'v4l2_subdev_state_get_format'
       v4l2_subdev_state_get_format(fh->state, i);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1557:55: error: 'stream' undeclared (first use in this function); did you mean 'strim'?
            __v4l2_subdev_state_get_format_ ## __VA_OPT__(stream) \
                                                          ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:39:4: note: in expansion of macro 'v4l2_subdev_state_get_format'
       v4l2_subdev_state_get_format(fh->state, i);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1557:55: note: each undeclared identifier is reported only once for each function it appears in
            __v4l2_subdev_state_get_format_ ## __VA_OPT__(stream) \
                                                          ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:39:4: note: in expansion of macro 'v4l2_subdev_state_get_format'
       v4l2_subdev_state_get_format(fh->state, i);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1558:21: error: expected ')' before '__VA_OPT__'
            (state, pad __VA_OPT__(,) __VA_ARGS__)
                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:39:4: note: in expansion of macro 'v4l2_subdev_state_get_format'
       v4l2_subdev_state_get_format(fh->state, i);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1580:9: error: implicit declaration of function '__v4l2_subdev_state_get_crop___VA_OPT__'; did you mean '__v4l2_subdev_state_get_crop_stream'? [-Werror=implicit-function-declaration]
            __v4l2_subdev_state_get_crop_ ## __VA_OPT__(stream) \
            ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:47:3: note: in expansion of macro 'v4l2_subdev_state_get_crop'
     *v4l2_subdev_state_get_crop(fh->state, IMGU_NODE_IN) = try_crop;
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1581:21: error: expected ')' before '__VA_OPT__'
            (state, pad __VA_OPT__(,) __VA_ARGS__)
                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:47:3: note: in expansion of macro 'v4l2_subdev_state_get_crop'
     *v4l2_subdev_state_get_crop(fh->state, IMGU_NODE_IN) = try_crop;
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/media/v4l2-subdev.h:1603:9: error: implicit declaration of function '__v4l2_subdev_state_get_compose___VA_OPT__'; did you mean '__v4l2_subdev_state_get_compose_stream'? [-Werror=implicit-function-declaration]
            __v4l2_subdev_state_get_compose_ ## __VA_OPT__(stream) \
            ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:48:3: note: in expansion of macro 'v4l2_subdev_state_get_compose'
     *v4l2_subdev_state_get_compose(fh->state, IMGU_NODE_IN) = try_crop;
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1604:21: error: expected ')' before '__VA_OPT__'
            (state, pad __VA_OPT__(,) __VA_ARGS__)
                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:48:3: note: in expansion of macro 'v4l2_subdev_state_get_compose'
     *v4l2_subdev_state_get_compose(fh->state, IMGU_NODE_IN) = try_crop;
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'imgu_subdev_get_fmt':
   include/media/v4l2-subdev.h:1557:55: error: 'stream' undeclared (first use in this function); did you mean 'strim'?
            __v4l2_subdev_state_get_format_ ## __VA_OPT__(stream) \
                                                          ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:139:8: note: in expansion of macro 'v4l2_subdev_state_get_format'
      mf = v4l2_subdev_state_get_format(sd_state, pad);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1558:21: error: expected ')' before '__VA_OPT__'
            (state, pad __VA_OPT__(,) __VA_ARGS__)
                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:139:8: note: in expansion of macro 'v4l2_subdev_state_get_format'
      mf = v4l2_subdev_state_get_format(sd_state, pad);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'imgu_subdev_set_fmt':
   include/media/v4l2-subdev.h:1557:55: error: 'stream' undeclared (first use in this function); did you mean 'strim'?
            __v4l2_subdev_state_get_format_ ## __VA_OPT__(stream) \
                                                          ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:164:8: note: in expansion of macro 'v4l2_subdev_state_get_format'
      mf = v4l2_subdev_state_get_format(sd_state, pad);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1558:21: error: expected ')' before '__VA_OPT__'
            (state, pad __VA_OPT__(,) __VA_ARGS__)
                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:164:8: note: in expansion of macro 'v4l2_subdev_state_get_format'
      mf = v4l2_subdev_state_get_format(sd_state, pad);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'imgu_subdev_get_crop':
   include/media/v4l2-subdev.h:1580:53: error: 'stream' undeclared (first use in this function); did you mean 'strim'?
            __v4l2_subdev_state_get_crop_ ## __VA_OPT__(stream) \
                                                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:197:10: note: in expansion of macro 'v4l2_subdev_state_get_crop'
      return v4l2_subdev_state_get_crop(sd_state, pad);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1581:21: error: expected ')' before '__VA_OPT__'
            (state, pad __VA_OPT__(,) __VA_ARGS__)
                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:197:10: note: in expansion of macro 'v4l2_subdev_state_get_crop'
      return v4l2_subdev_state_get_crop(sd_state, pad);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'imgu_subdev_get_compose':
   include/media/v4l2-subdev.h:1603:56: error: 'stream' undeclared (first use in this function); did you mean 'strim'?
            __v4l2_subdev_state_get_compose_ ## __VA_OPT__(stream) \
                                                           ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:208:10: note: in expansion of macro 'v4l2_subdev_state_get_compose'
      return v4l2_subdev_state_get_compose(sd_state, pad);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-subdev.h:1604:21: error: expected ')' before '__VA_OPT__'
            (state, pad __VA_OPT__(,) __VA_ARGS__)
                        ^
   drivers/staging/media/ipu3/ipu3-v4l2.c:208:10: note: in expansion of macro 'v4l2_subdev_state_get_compose'
      return v4l2_subdev_state_get_compose(sd_state, pad);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'imgu_subdev_get_crop':
>> drivers/staging/media/ipu3/ipu3-v4l2.c:200:1: error: control reaches end of non-void function [-Werror=return-type]
    }
    ^
   drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'imgu_subdev_get_compose':
   drivers/staging/media/ipu3/ipu3-v4l2.c:211:1: error: control reaches end of non-void function [-Werror=return-type]
    }
    ^
   cc1: some warnings being treated as errors


vim +200 drivers/staging/media/ipu3/ipu3-v4l2.c

a0ca1627b4501d Yong Zhi       2018-12-06  190  
dc608edf7d45ba Maximilian Luz 2022-09-08  191  static struct v4l2_rect *
dc608edf7d45ba Maximilian Luz 2022-09-08  192  imgu_subdev_get_crop(struct imgu_v4l2_subdev *sd,
dc608edf7d45ba Maximilian Luz 2022-09-08  193  		     struct v4l2_subdev_state *sd_state, unsigned int pad,
dc608edf7d45ba Maximilian Luz 2022-09-08  194  		     enum v4l2_subdev_format_whence which)
dc608edf7d45ba Maximilian Luz 2022-09-08  195  {
dc608edf7d45ba Maximilian Luz 2022-09-08  196  	if (which == V4L2_SUBDEV_FORMAT_TRY)
664ffe0ad78d9d Sakari Ailus   2023-10-13  197  		return v4l2_subdev_state_get_crop(sd_state, pad);
dc608edf7d45ba Maximilian Luz 2022-09-08  198  	else
dc608edf7d45ba Maximilian Luz 2022-09-08  199  		return &sd->rect.eff;
dc608edf7d45ba Maximilian Luz 2022-09-08 @200  }
dc608edf7d45ba Maximilian Luz 2022-09-08  201  

:::::: The code at line 200 was first introduced by commit
:::::: dc608edf7d45ba0c2ad14c06eccd66474fec7847 ipu3-imgu: Fix NULL pointer dereference in imgu_subdev_set_selection()

:::::: TO: Maximilian Luz <luzmaximilian@xxxxxxxxx>
:::::: CC: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux