Hi Laurent,
On Tue, Oct 24, 2023 at 10:21:02AM +0300, Laurent Pinchart wrote:
> On Tue, Oct 24, 2023 at 05:54:39AM +0000, Sakari Ailus wrote:
> > Hi Laurent,
> >
> > On Tue, Oct 24, 2023 at 01:13:39AM +0300, Laurent Pinchart wrote:
> > > Hi Sakari,
> > >
> > > Thank you for the patch.
> > >
> > > On Mon, Oct 23, 2023 at 08:44:06PM +0300, Sakari Ailus wrote:
> > > > diff --git b/drivers/media/i2c/s5k5baf.c a/drivers/media/i2c/s5k5baf.c
> > > > index a36b310b32e1..3f3005cca9d0 100644
> > > > --- b/drivers/media/i2c/s5k5baf.c
> > > > +++ a/drivers/media/i2c/s5k5baf.c
> > > > @@ -1473,12 +1473,10 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
> > > > if (sel->which == V4L2_SUBDEV_FORMAT_TRY) {
> > > > rects = (struct v4l2_rect * []) {
> > > > &s5k5baf_cis_rect,
> > > > - v4l2_subdev_get_try_crop(sd, sd_state,
> > > > - PAD_CIS),
> > > > - v4l2_subdev_get_try_compose(sd, sd_state,
> > > > - PAD_CIS),
> > > > - v4l2_subdev_get_try_crop(sd, sd_state,
> > > > - PAD_OUT)
> > > > + v4l2_subdev_state_get_crop(sd_state, PAD_CIS),
> > > > + v4l2_subdev_state_get_compose(sd_state,
> > > > + PAD_CIS),
> > >
> > > A single line would be more readable I think.
> >
> > But over 80.
>
> By one character. Given the relaxed limit, this is one of the cases
> where going to 81 columns inmproves readability.
I fixed the alignment of all entries of the array, now it's less than 80
and all entries fit on a single line. :-)
--
Regards,
Sakari Ailus
