Re: [PATCH v2 5/6] media: v4l: subdev: Switch to stream-aware state functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on next-20231023]
[cannot apply to rockchip/for-next sailus-media-tree/streams linus/master v6.6-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-subdev-Also-return-pads-array-information-on-stream-functions/20231023-203626
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20231023123308.782592-6-sakari.ailus%40linux.intel.com
patch subject: [PATCH v2 5/6] media: v4l: subdev: Switch to stream-aware state functions
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231023/202310232249.qOLKJuzq-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231023/202310232249.qOLKJuzq-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310232249.qOLKJuzq-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/media/i2c/imx319.c: In function 'imx319_do_get_pad_format':
>> drivers/media/i2c/imx319.c:2004:29: warning: unused variable 'sd' [-Wunused-variable]
    2004 |         struct v4l2_subdev *sd = &imx319->sd;
         |                             ^~
--
   drivers/media/i2c/imx355.c: In function 'imx355_do_get_pad_format':
>> drivers/media/i2c/imx355.c:1302:29: warning: unused variable 'sd' [-Wunused-variable]
    1302 |         struct v4l2_subdev *sd = &imx355->sd;
         |                             ^~
--
   drivers/media/i2c/ov08x40.c: In function 'ov08x40_do_get_pad_format':
>> drivers/media/i2c/ov08x40.c:2777:29: warning: unused variable 'sd' [-Wunused-variable]
    2777 |         struct v4l2_subdev *sd = &ov08x->sd;
         |                             ^~
--
   drivers/media/i2c/ov13858.c: In function 'ov13858_do_get_pad_format':
>> drivers/media/i2c/ov13858.c:1319:29: warning: unused variable 'sd' [-Wunused-variable]
    1319 |         struct v4l2_subdev *sd = &ov13858->sd;
         |                             ^~
--
   drivers/media/i2c/ov13b10.c: In function 'ov13b10_do_get_pad_format':
>> drivers/media/i2c/ov13b10.c:1004:29: warning: unused variable 'sd' [-Wunused-variable]
    1004 |         struct v4l2_subdev *sd = &ov13b->sd;
         |                             ^~
--
   drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function 's5c73m3_oif_try_format':
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c:822:29: warning: unused variable 'sd' [-Wunused-variable]
     822 |         struct v4l2_subdev *sd = &state->sensor_sd;
         |                             ^~


vim +/sd +2004 drivers/media/i2c/imx319.c

8a89dc62f28c48 Bingbu Cao     2018-09-25  1998  
8a89dc62f28c48 Bingbu Cao     2018-09-25  1999  static int imx319_do_get_pad_format(struct imx319 *imx319,
0d346d2a6f54f0 Tomi Valkeinen 2021-06-10  2000  				    struct v4l2_subdev_state *sd_state,
8a89dc62f28c48 Bingbu Cao     2018-09-25  2001  				    struct v4l2_subdev_format *fmt)
8a89dc62f28c48 Bingbu Cao     2018-09-25  2002  {
8a89dc62f28c48 Bingbu Cao     2018-09-25  2003  	struct v4l2_mbus_framefmt *framefmt;
8a89dc62f28c48 Bingbu Cao     2018-09-25 @2004  	struct v4l2_subdev *sd = &imx319->sd;
8a89dc62f28c48 Bingbu Cao     2018-09-25  2005  
8a89dc62f28c48 Bingbu Cao     2018-09-25  2006  	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
e3851498f6c205 Sakari Ailus   2023-10-23  2007  		framefmt = v4l2_subdev_state_get_format(sd_state, fmt->pad);
8a89dc62f28c48 Bingbu Cao     2018-09-25  2008  		fmt->format = *framefmt;
8a89dc62f28c48 Bingbu Cao     2018-09-25  2009  	} else {
8a89dc62f28c48 Bingbu Cao     2018-09-25  2010  		imx319_update_pad_format(imx319, imx319->cur_mode, fmt);
8a89dc62f28c48 Bingbu Cao     2018-09-25  2011  	}
8a89dc62f28c48 Bingbu Cao     2018-09-25  2012  
8a89dc62f28c48 Bingbu Cao     2018-09-25  2013  	return 0;
8a89dc62f28c48 Bingbu Cao     2018-09-25  2014  }
8a89dc62f28c48 Bingbu Cao     2018-09-25  2015  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux