On Mon, Oct 23, 2023 at 08:23:23AM +0200, Andreas Helbech Kleist wrote:
> On Fri, 2023-10-20 at 16:39 +0200, Hans de Goede wrote:
> > On 10/20/23 12:47, Andreas Helbech Kleist wrote:
...
> > But it does have an effect, modprobe will load both the main
> > ipu6 driver registering the aux devices as well as this driver
> > based on the modalias of the PCI device because with this
> > MODULE_DEVICE_TABLE(pci, isys_pci_tbl); statement both drivers
> > match that PCI modalias.
>
> All right. But since the main driver contains the same table, I don't
> think there's any need to have it here?
>
> > But the correct thing to do here would be to switch to
> > an auxbus based MODULE_DEVICE_TABLE() for the isys driver.
>
> The isys_driver already has an auxiliary_device_id table. I'm not sure
> if that's what you mean?
>
> From the bottom of ipu6-isys.c in PATCH 10/15:
>
> +static const struct auxiliary_device_id ipu6_isys_id_table[] = {
> + {
> + .name = "intel_ipu6.isys",
> + .driver_data = (kernel_ulong_t)&ipu6_isys_auxdrv_data,
> + },
Should be {} here...
> +};
...and MODULE_DEVICE_TABLE() here.
--
With Best Regards,
Andy Shevchenko
