Hey Rob and Krzysztof,
On 16.10.2023 08:47, Rob Herring wrote:
On Thu, Oct 12, 2023 at 03:24:12PM +0200, Krzysztof Kozlowski wrote:
On 12/10/2023 13:01, Sebastian Fricke wrote:
> From: Robert Beckett <bob.beckett@xxxxxxxxxxxxx>
>
> Add bindings for the chips&media wave5 codec driver
>
> Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/cnm,wave5.yaml | 60 ++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/cnm,wave5.yaml b/Documentation/devicetree/bindings/media/cnm,wave5.yaml
> new file mode 100644
> index 000000000000..b31d34aec05b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/cnm,wave5.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/cnm,wave5.yaml#
Filename matching compatible, so: cnm,cm521c-vpu.yaml
With which compatible should the filename match? (see below)
And just to be sure, this means that I rename the file to:
`.../devicetree/bindings/media/cnm,wave521c.yaml`
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chips&Media Wave 5 Series multi-standard codec IP
> +
> +maintainers:
> + - Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
> + - Jackson Lee <jackson.lee@xxxxxxxxxxxxxxx>
> +
> +description:
> + The Chips&Media WAVE codec IP is a multi format video encoder/decoder
> +
> +properties:
> + compatible:
> + enum:
> + - cnm,cm521c-vpu
Can this device be anything else? Why VPU suffix?
It needs an SoC specific compatible (TI something...) as well (or
instead). Unless there's a public spec with details on how many
clocks, resets, interrupts, etc. there are.
Okay so how about this, a bit similar to the Coda driver supplying both
a general option and a SoC specific version:
properties:
compatible:
enum:
- ti,k3-j721sX-wave521c
- cnm,wave521c
(ti,k3-j721sX-wave521c = manufacturer,SoC-codec)
(tested on j721s2 but should work on other variations as well)
Another alternative could be: ti,k3-wave521c (less specific on a single
SoC series but connected to a bigger range of devices)
Rob
Regards,
Sebastian
_______________________________________________
Kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxx
