Re: [PATCH 5/7] media: mediatek: vcodec: Setting the supported h265 profile for each platform

[Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>]

Hey Yunfei,

Please replace Setting with Set in the title.

On 16.10.2023 14:43, Yunfei Dong wrote:
> The supported format type of different platforms are not the
> same. Need to set the supported profile according to the chip name.

I would suggest the following rewording:

Set the maximum H265 codec profile for each platform.
The various mediatek platforms support different profiles for decoding,
the profile of the codec limits the capabilities for decoding.

With that you can add:
Reviewed-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>

Regards,
Sebastian

> Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>
> ---
> .../vcodec/decoder/mtk_vcodec_dec_stateless.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> index 84c0bed577ed..b15ed773374f 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> @@ -587,6 +587,20 @@ static void mtk_vcodec_dec_fill_h265_level(struct v4l2_ctrl_config *cfg,
> 	};
> }
>
> +static void mtk_vcodec_dec_fill_h265_profile(struct v4l2_ctrl_config *cfg,
> +					     struct mtk_vcodec_dec_ctx *ctx)
> +{
> +	switch (ctx->dev->chip_name) {
> +	case MTK_VDEC_MT8188:
> +	case MTK_VDEC_MT8195:
> +		cfg->max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10;
> +		break;
> +	default:
> +		cfg->max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE;
> +		break;
> +	};
> +}
> +
> static void mtk_vcodec_dec_reset_controls(struct v4l2_ctrl_config *cfg,
> 					  struct mtk_vcodec_dec_ctx *ctx)
> {
> @@ -604,6 +618,11 @@ static void mtk_vcodec_dec_reset_controls(struct v4l2_ctrl_config *cfg,
> 		mtk_v4l2_vdec_dbg(3, ctx, "h264 supported profile: %lld %lld", cfg->max,
> 				  cfg->menu_skip_mask);
> 		break;
> +	case V4L2_CID_MPEG_VIDEO_HEVC_PROFILE:
> +		mtk_vcodec_dec_fill_h265_profile(cfg, ctx);
> +		mtk_v4l2_vdec_dbg(3, ctx, "h265 supported profile: %lld %lld", cfg->max,
> +				  cfg->menu_skip_mask);
> +		break;
> 	default:
> 		break;
> 	};
> --
> 2.18.0