Hi Mehdi, On Mon 16 Oct 23, 11:00, Mehdi Djait wrote: > The PX30 has a camera interface, supporting CSI2 and BT656 > modes. Add a DT description for this interface. The "vip" node name is not very standard but the generic names recommendation doesn't have anything that really fits video capture: https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#generic-names-recommendation You might want to call it "video-capture" or "camera-controller" which seems like a good middle-ground that could be included in the list. Please keep the name (vip/cif) as label though. Other than that, please rename vip to cif and this will be: Reviewed-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> Cheers, Paul > Signed-off-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index 42ce78beb413..7aaa88a15d07 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -1281,6 +1281,18 @@ isp_mmu: iommu@ff4a8000 { > #iommu-cells = <0>; > }; > > + vip: vip@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>; > + clock-names = "aclk", "hclk", "pclk"; > + power-domains = <&power PX30_PD_VI>; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + status = "disabled"; > + }; > + > qos_gmac: qos@ff518000 { > compatible = "rockchip,px30-qos", "syscon"; > reg = <0x0 0xff518000 0x0 0x20>; > -- > 2.41.0 > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
