Andy,
------------------------------------------------------------------------
BRs,
Bingbu Cao
>-----Original Message-----
>From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>Sent: Thursday, October 19, 2023 8:22 PM
>To: Bingbu Cao <bingbu.cao@xxxxxxxxxxxxxxx>
>Cc: Andreas Helbech Kleist <andreaskleist@xxxxxxxxx>; Cao, Bingbu
><bingbu.cao@xxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx;
>sakari.ailus@xxxxxxxxxxxxxxx; laurent.pinchart@xxxxxxxxxxxxxxxx;
>ilpo.jarvinen@xxxxxxxxxxxxxxx; tfiga@xxxxxxxxxxxx; senozhatsky@xxxxxxxxxxxx;
>hdegoede@xxxxxxxxxx; tomi.valkeinen@xxxxxxxxxxxxxxxx; Qiu, Tian Shu
><tian.shu.qiu@xxxxxxxxx>; Wang, Hongju <hongju.wang@xxxxxxxxx>
>Subject: Re: [PATCH 10/15] media: intel/ipu6: add input system driver
>
>On Thu, Oct 19, 2023 at 04:28:16PM +0800, Bingbu Cao wrote:
>> On 10/3/23 6:13 PM, Andreas Helbech Kleist wrote:
>> > On Thu, 2023-07-27 at 15:15 +0800, bingbu.cao@xxxxxxxxx wrote:
>
>...
>
>> >> +static const struct pci_device_id isys_pci_tbl[] = {
>> >> + { PCI_VDEVICE(INTEL, IPU6_PCI_ID) },
>> >> + { PCI_VDEVICE(INTEL, IPU6SE_PCI_ID) },
>> >> + { PCI_VDEVICE(INTEL, IPU6EP_ADL_P_PCI_ID) },
>> >> + { PCI_VDEVICE(INTEL, IPU6EP_ADL_N_PCI_ID) },
>> >> + { PCI_VDEVICE(INTEL, IPU6EP_RPL_P_PCI_ID) },
>> >> + { PCI_VDEVICE(INTEL, IPU6EP_MTL_PCI_ID) },
>> >> + { }
>> >> +};
>> >
>> > Unused
>>
>> Have you tried that whether isys driver can be auto-loaded w/o this
>> pci id table? It cannot on my side.
>
>But where is the respective MODULE_DEVICE_TABLE()?
It is at the end of this source, someone snip it in mail.
+static struct auxiliary_driver isys_driver = {
+ .name = IPU6_ISYS_NAME,
+ .probe = isys_probe,
+ .remove = isys_remove,
+ .id_table = ipu6_isys_id_table,
+ .driver = {
+ .pm = &isys_pm_ops,
+ },
+};
+
+module_auxiliary_driver(isys_driver);
+
+MODULE_DEVICE_TABLE(pci, isys_pci_tbl);
>
>--
>With Best Regards,
>Andy Shevchenko
>
