On Wed, Oct 18, 2023 at 03:38:56PM +0300, Laurent Pinchart wrote: > On Wed, Oct 18, 2023 at 11:12:12AM +0530, Umang Jain wrote: > > VC04 has now a independent bus vchiq_bus to register its devices. > > However, the module auto-loading for bcm2835-audio and bcm2835-camera > > currently happens through MODULE_ALIAS() macro specified explicitly. > > > > The correct way to auto-load a module, is when the alias is picked > > out from MODULE_DEVICE_TABLE(). In order to get there, we need to > > introduce vchiq_device_id and add relevant entries in file2alias.c > > infrastructure so that aliases can be generated. This patch targets > > adding vchiq_bus_device_id and do_vchiq_bus_entry, in order to > > generate those alias using the /script/mod/file2alias.c. > > > > Going forward the MODULE_ALIAS() from bcm2835-camera and bcm2835-audio > > will be dropped, in favour of MODULE_DEVICE_TABLE being used there. > > > > The alias format for vchiq_bus devices will be "vchiq_bus:<dev_name>". > > Adjust the vchiq_bus_uevent() to reflect that. > > None of the other buses have a "_bus" suffix in the alias or in the > *_device_id structure name. Is there a reason to make an exception here? No, it should be dropped, good catch. thanks, greg k-h
