Hi Laurent, On Tue, Oct 17, 2023 at 02:36:09PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Tue, Oct 17, 2023 at 01:56:30PM +0300, Sakari Ailus wrote: > > LP-11 and LP-111 are CSI-2 bus states, not modes. Fix this. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > Documentation/driver-api/media/tx-rx.rst | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/driver-api/media/tx-rx.rst b/Documentation/driver-api/media/tx-rx.rst > > index 7e115e3c4735..bc1b94cffdd9 100644 > > --- a/Documentation/driver-api/media/tx-rx.rst > > +++ b/Documentation/driver-api/media/tx-rx.rst > > @@ -89,13 +89,13 @@ where > > pixel rate on the camera sensor's pixel array which is indicated by the > > :ref:`V4L2_CID_PIXEL_RATE <v4l2-cid-pixel-rate>` control. > > > > -LP-11 and LP-111 modes > > -^^^^^^^^^^^^^^^^^^^^^^ > > +LP-11 and LP-111 states > > +^^^^^^^^^^^^^^^^^^^^^^^ > > Indeed. > > > > > -As part of transitioning to high speed mode, a CSI-2 transmitter typically > > +As part of transitioning to high speed state, a CSI-2 transmitter typically > > "high speed" is a mode according to the D-PHY specification. Yes, indeed. I'll address these in v3. > > > briefly sets the bus to LP-11 or LP-111 state, depending on the PHY. This period > > may be as short as 100 µs, during which the receiver observes this state and > > -proceeds its own part of high speed mode transition. > > +proceeds its own part of high speed state transition. > > Same here. > > > > > Most receivers are capable of autonomously handling this once the software has > > configured them to do so, but there are receivers which require software > > @@ -104,7 +104,7 @@ in software, especially when there is no interrupt telling something is > > happening. > > > > One way to address this is to configure the transmitter side explicitly to LP-11 > > -or LP-111 mode, which requires support from the transmitter hardware. This is > > +or LP-111 state, which requires support from the transmitter hardware. This is > > Ack. > > With the two changes referring to high speed state dropped, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Thanks! -- Regards, Sakari Ailus
