On 2023/10/16 19:40, Hans Verkuil wrote: > Hi Jack, > > On 08/10/2023 10:51, Jack Zhu wrote: >> Hi, >> >> This series is the v10 series that attempts to support the Camera Subsystem >> found on StarFive JH7110 SoC. >> >> This series is based on top of the master branch of media_stage repository, >> which is tested with a v4l2-compliance compiled from the git repo >> (git://linuxtv.org/v4l-utils.git). > > I get one smatch warning: > > drivers/staging/media/starfive/camss/stf-isp.c:122 isp_enum_mbus_code() warn: unsigned 'code->index' is never less than zero. > Could you please tell me the code check command? This way I can use it to check my next commit. > And I also notice that there is no TODO file: staging drivers should have a > TODO file explaining what needs to be done to get them out of staging. > OK, I'll add it to my next commit. I previously misunderstood that it was submitted when moving out of staging. > I'm curious to know that as well :-) > > It looks like there is a lot of additional development that can be done, since > most of the ISP parameters appear to be hardcoded. > Part is the module initialization configuration. In the next stage, we will use incremental development to implement 3A functions. -- Regards, Jack Zhu
