Hi. On Mon, 2010-10-18 at 15:57 +0200, ext Hans Verkuil wrote: > > Em 18-10-2010 11:17, Hans Verkuil escreveu: > >> Just a few very small comments: > > > >>> +For future use the > >>> +flag <constant>V4L2_TUNER_SUB_RDS_CONTROLS</constant> has also been > >>> +defined. However, a driver for a radio tuner with this capability does > >>> +not yet exist, so if you are planning to write such a driver the best > >>> +way to start would probably be by opening a discussion about it on > >>> +the linux-media mailing list: &v4l-ml;. </para> > >> > >> Change to: > >> > >> not yet exist, so if you are planning to write such a driver you > >> should discuss this on the linux-media mailing list: &v4l-ml;.</para> > > > > No, please. Don't add any API capabilities at the DocBook without having a > > driver > > using it. At the time a driver start needing it, we can just add the API > > bits > > and doing the needed discussions as you've proposed. This is already > > implicit. > > These caps are shared between tuner and modulator. And for the modulator > both caps *are* used in Matti's driver. But while RDS_CONTROLS is > available for modulators, it is not yet applicable to tuners and for that > we need to make this note in the spec. > > So this is an exception to the rule, I'm afraid. So it's ACK... or NACK? Cheers, Matti > Regards, > > Hans > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
