RE: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Nilofer, Samreen
> Sent: Monday, October 18, 2010 9:32 AM
> To: Hiremath, Vaibhav
> Cc: linux-media@xxxxxxxxxxxxxxx; Nilofer, Samreen
> Subject: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options
> on OMAP3
> 
> The defconfig options for V4L2 are taken in the respective Kconfig
> to enable V4L2 by default on OMAP3 platforms
> 
> Signed-off-by: Samreen <samreen@xxxxxx>
> ---
>  drivers/media/Kconfig            |    2 ++
>  drivers/media/video/omap/Kconfig |    2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index a28541b..2592d88 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -5,6 +5,7 @@
>  menuconfig MEDIA_SUPPORT
>  	tristate "Multimedia support"
>  	depends on HAS_IOMEM
> +	default y if ARCH_OMAP2 || ARCH_OMAP3
[Hiremath, Vaibhav] I am quite not sure whether this is right approach to do this, I think adding dependency of ARCH_ here will pollute the file.

Why not add this definition to omap2plus_defconfig, which is common defconfig file for all OMAP architecture.

Thanks,
Vaibhav

>  	help
>  	  If you want to use Video for Linux, DVB for Linux, or DAB
> adapters,
>  	  enable this option and other options below.
> @@ -19,6 +20,7 @@ comment "Multimedia core support"
> 
>  config VIDEO_DEV
>  	tristate "Video For Linux"
> +	default y if ARCH_OMAP2 || ARCH_OMAP3
>  	---help---
>  	  V4L core support for video capture and overlay devices, webcams
> and
>  	  AM/FM radio cards.
> diff --git a/drivers/media/video/omap/Kconfig
> b/drivers/media/video/omap/Kconfig
> index e63233f..f3e33c3 100644
> --- a/drivers/media/video/omap/Kconfig
> +++ b/drivers/media/video/omap/Kconfig
> @@ -6,6 +6,6 @@ config VIDEO_OMAP2_VOUT
>  	select OMAP2_DSS
>  	select OMAP2_VRAM
>  	select OMAP2_VRFB
> -	default n
> +	default y
>  	---help---
>  	  V4L2 Display driver support for OMAP2/3 based boards.
> --
> 1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux