Hi Laurent, Thanks for the review. On Fri, Oct 13, 2023 at 01:57:49PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Oct 13, 2023 at 01:44:19PM +0300, Sakari Ailus wrote: > > Store the number of pads in the sub-device state. This will be needed to > > validate pad when retrieving information for non-stream-aware users. > > I'd rather store a pointer to the subdev. You can get the number of pads > from there. The value is initialised after the array is allocated so this won't change. I don't have a strong opinion either way. It's still more efficient to store just the value. -- Regards, Sakari Ailus
