Moi, On Thu, Oct 05, 2023 at 04:12:00PM +0300, Tomi Valkeinen wrote: > On 03/10/2023 15:07, Sakari Ailus wrote: > > Add a helper for obtaining format, crop and compose pointers. These are > > convenient for drivers, independently of the driver uses streams or not. > > If we go with these, should we deprecate > v4l2_subdev_state_get_stream_format() and v4l2_subdev_get_pad_format()? > > Having three different ways to get the fmt seems a bit excessive. > > Should we add 'num_pads' to the state? That would remove the need pass the > subdevice to these functions. Good question. This would make it easier to refactor the code later, drivers would still need to begin calling v4l2_subdev_init_finalize(). But it's one step forward I think. I'll add this earlier in the set. -- Terveisin, Sakari Ailus
