On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > - serialize the suspend and resume functions using the global lock. > - do not call usb_autopm_put_interface after a disconnect. > - fix a race when disconnecting the device. > > Reported-by: David Ellingsworth <david@xxxxxxxxxxxxxxxxx> > Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx> > --- > drivers/media/radio/radio-mr800.c | 17 ++++++++++++++--- > 1 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/radio/radio-mr800.c b/drivers/media/radio/radio-mr800.c > index 2f56b26..b540e80 100644 > --- a/drivers/media/radio/radio-mr800.c > +++ b/drivers/media/radio/radio-mr800.c > @@ -284,9 +284,13 @@ static void usb_amradio_disconnect(struct usb_interface *intf) > struct amradio_device *radio = to_amradio_dev(usb_get_intfdata(intf)); > > mutex_lock(&radio->lock); > + /* increase the device node's refcount */ > + get_device(&radio->videodev.dev); > v4l2_device_disconnect(&radio->v4l2_dev); > - mutex_unlock(&radio->lock); > video_unregister_device(&radio->videodev); > + mutex_unlock(&radio->lock); > + /* decrease the device node's refcount, allowing it to be released */ > + put_device(&radio->videodev.dev); > } Hans, I understand the use of get/put_device here.. but can you explain to me what issue you are trying to solve? video_unregister_device does not have to be synchronized with anything else. Thus, it is perfectly safe to call video_unregister_device while not holding the device lock. Your prior implementation here was correct. Regards, David Ellingsworth -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
