Hi On Mon, Oct 2, 2023 at 11:08 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Thu, Sep 28, 2023 at 05:00:09PM +0800, Shengjiu Wang wrote: > > > m2m_start_part_one: first part of the start steps > > m2m_start_part_two: second part of the start steps > > m2m_stop_part_one: first part of stop steps > > m2m_stop_part_two: second part of stop steps, optional > > The part_one/two naming isn't amazing here. Looking at the rest of the > code it looks like this is a prepare/trigger type distinction where the > first part is configuring things prior to DMA setup and the second part > is actually starting the transfer. Perhaps _config()/_start() instead? Ok, I will use m2m_prepare/m2m_unprepare to replace m2m_start_part_one/m2m_stop_part_one, and use m2m_start/m2m_stop to replace m2m_start_part_two/m2m_stop_part_two. Best regards Wang shengjiu