[PATCH] SR030PC30: Avoid use of uninitialized variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fix the following compilation warnings:

drivers/media/video/sr030pc30.c: In function âcam_i2c_writeâ:
drivers/media/video/sr030pc30.c:356: warning: âretâ may be used uninitialized in this function
drivers/media/video/sr030pc30.c: In function âsr030pc30_set_paramsâ:
drivers/media/video/sr030pc30.c:345: warning: âretâ may be used uninitialized in this function
drivers/media/video/sr030pc30.c:328: note: âretâ was declared here

Reported-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

---
Unfortunately I could not reproduce all the warnings in various build configurations,
this patch fixes the only issue I was able to find.
---
 drivers/media/video/sr030pc30.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/sr030pc30.c b/drivers/media/video/sr030pc30.c
index ec8d875..c9dc67a 100644
--- a/drivers/media/video/sr030pc30.c
+++ b/drivers/media/video/sr030pc30.c
@@ -326,7 +326,7 @@ static inline struct sr030pc30_info *to_sr030pc30(struct v4l2_subdev *sd)
 static inline int set_i2c_page(struct sr030pc30_info *info,
 			       struct i2c_client *client, unsigned int reg)
 {
-	int ret;
+	int ret = 0;
 	u32 page = reg >> 8 & 0xFF;
 
 	if (info->i2c_reg_page != page && (reg & 0xFF) != 0x03) {
-- 
1.7.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux