Re: [PATCH] Documentation: media: gen-errors.rst: fix confusing ENOTTY description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

thanks for the quick adjustment.

Le vendredi 06 octobre 2023 à 15:45 +0200, Hans Verkuil a écrit :
> The text is very, very old and predates /dev/mediaX devices, so the
> reference to "media device" is today very confusing.
> 
> It also says that the ioctl is not supported by the driver, but a
> driver may have multiple device nodes, some support a given ioctl,
> and some don't.
> 
> Simplify the description: ENOTTY means that the ioctl is not supported
> by the file descriptor.
> 
> Reported-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>

> ---
> diff --git a/Documentation/userspace-api/media/gen-errors.rst b/Documentation/userspace-api/media/gen-errors.rst
> index e595d0bea109..4e8defd3612b 100644
> --- a/Documentation/userspace-api/media/gen-errors.rst
> +++ b/Documentation/userspace-api/media/gen-errors.rst
> @@ -59,9 +59,7 @@ Generic Error Codes
> 
>      -  -  ``ENOTTY``
> 
> -       -  The ioctl is not supported by the driver, actually meaning that
> -	  the required functionality is not available, or the file
> -	  descriptor is not for a media device.
> +       -  The ioctl is not supported by the file descriptor.
> 
>      -  -  ``ENOSPC``
> 





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux