Hi Hans, On Thu, Oct 05, 2023 at 12:10:29PM +0200, Hans Verkuil wrote: > On 03/10/2023 13:52, Sakari Ailus wrote: > > Document how embedded data support should be implemented for camera > > sensors, and when and how CCS embedded data format should be referenced. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > .../media/drivers/camera-sensor.rst | 28 +++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/Documentation/userspace-api/media/drivers/camera-sensor.rst b/Documentation/userspace-api/media/drivers/camera-sensor.rst > > index 919a50e8b9d9..308f391c5ca1 100644 > > --- a/Documentation/userspace-api/media/drivers/camera-sensor.rst > > +++ b/Documentation/userspace-api/media/drivers/camera-sensor.rst > > @@ -102,3 +102,31 @@ register programming sequences shall initialize the :ref:`V4L2_CID_HFLIP > > values programmed by the register sequences. The default values of these > > controls shall be 0 (disabled). Especially these controls shall not be inverted, > > independently of the sensor's mounting rotation. > > + > > +Embedded data > > +------------- > > + > > +Many sensors, mostly raw sensors, support embedded data which is used to convey > > +the sensor configuration for the captured frame back to the host. While CSI-2 is > > +the most common bus used by such sensors, embedded data is not entirely limited > > +to CSI-2 bus due to e.g. bridge devices. > > I'm not quite sure what you mean with "embedded data is not entirely limited > to CSI-2 bus due to e.g. bridge devices": do you just want to say: "embedded data > can be available on other bus types as well."? Bridge devices that transmit what they received over CSI-2 may result in embedded data on parallel bus, for instance. I'm fine with using the text you suggested, it's equally true as well. > > > + > > +Embedded data support should use an internal source pad and route to the > > should or shall/must? I'll change this to shall. -- Regards, Sakari Ailus
