Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Wednesday, October 4, 2023 3:51 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@xxxxxxxxxxxxx>; hverkuil@xxxxxxxxx; > laurent.pinchart@xxxxxxxxxxxxxxxx; mchehab@xxxxxxxxxx; > robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) > <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba > Visconti Video Input Interface > > On 04/10/2023 01:10, yuji2.ishikawa@xxxxxxxxxxxxx wrote: > >>> + properties: > >>> + endpoint: > >>> + $ref: video-interfaces.yaml# > >>> + additionalProperties: false > >> > >> This is a friendly reminder during the review process. > >> > >> It seems my previous comments were not fully addressed. Maybe my > >> feedback got lost between the quotes, maybe you just forgot to apply it. > >> Please go back to the previous discussion and either implement all > >> requested changes or keep discussing them. > >> > >> Thank you. > > > > I'm very sorry that I misunderstood the intent of the last conversion. > > https://lore.kernel.org/all/0aa471ce-da83-172d-d870-1ec7a562baf7@linar > > o.org/ I thought "additionalProperties: false" can be used and > > "xxx:true" should stay. > > > > Let me confirm your intentions: > > - "unevaluatedProperties: false" should be used instead of > "additionalProperties: false" > > - All of "xxx: true" should be removed Are these two correct > > understandings? > > Ah, true, I missed that. It is indeed fine, apologies. > I understand. I'll use "additionalProperties: false". > > > >>> + > >>> + properties: > >>> + data-lanes: > >>> + description: VIIF supports 1, 2, 3 or 4 data lanes > >>> + minItems: 1 > >>> + items: > >>> + - const: 1 > >>> + - const: 2 > >>> + - const: 3 > >>> + - const: 4 > >>> + > >>> + clock-noncontinuous: true > >> > >> Drop > > This and further can be ignored. I'll keep "xxx: true". > Best regards, > Krzysztof Best regards, Yuji
