Re: [PATCH 7/7] media: ov2740: Return -EPROBE_DEFER if no endpoint is found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On Fri, Sep 15, 2023 at 12:50:27PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
> 
> Thank you for the patch.
> 
> On Fri, Sep 15, 2023 at 10:28:09AM +0300, Sakari Ailus wrote:
> > With ipu bridge, endpoints may only be created when ipu bridge has
> > initialised. This may happen after the sensor driver has first probed.
> 
> That's hard to understand for someone not familiar with the ipu-bridge
> driver. Could you please expand the commit message ?
> 
> Also, is there a way to avoid the ov2740 probing before the required
> initialization is complete ?

One possibility would be to move the ipu bridge functionality to the ACPI
framework itself. Then it'd be independent of probing any drivers. It
hasn't been discussed and I'm not sure what the result might be. In any
case I'd like to have DisCo for Imaging support there first.

Cc Hans.

> 
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/media/i2c/ov2740.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
> > index de39a66b1b81..a132e8a283b4 100644
> > --- a/drivers/media/i2c/ov2740.c
> > +++ b/drivers/media/i2c/ov2740.c
> > @@ -976,7 +976,7 @@ static int ov2740_check_hwcfg(struct device *dev)
> >  
> >  	ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
> >  	if (!ep)
> > -		return -ENXIO;
> > +		return -EPROBE_DEFER;
> >  
> >  	ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
> >  	fwnode_handle_put(ep);
> 

-- 
Regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux