Hi Arnd,
On Wed, Sep 27, 2023 at 09:21:19AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Some missing select statements were already added back, but I ran into
> another one that is missing:
>
> ERROR: modpost: "v4l2_fwnode_endpoint_free" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
> ERROR: modpost: "v4l2_fwnode_endpoint_alloc_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
> ERROR: modpost: "v4l2_fwnode_endpoint_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
>
> Fixes: 29006e196a566 ("media: pci: intel: ivsc: Add CSI submodule")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/media/pci/intel/ivsc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig
> index 0acea4678fc0d..6a2995b02d274 100644
> --- a/drivers/media/pci/intel/ivsc/Kconfig
> +++ b/drivers/media/pci/intel/ivsc/Kconfig
> @@ -7,6 +7,7 @@ config INTEL_VSC
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_ASYNC
> + select V4L2_FWNODE
Thanks for the fix.
V4L2_FWNODE already implies V4L2_ASYNC so V4L2_ASYNC can be removed. I
somehow thought this only needed V4L2_ASYNC but that indeed is not the
case.
I'll just drop the line selecting V4L2_ASYNC above if that's fine.
> help
> This adds support for Intel Visual Sensing Controller (IVSC).
>
--
Regards,
Sakari Ailus
