On 27/09/2023 04:10, Ming Qian wrote: >> From: Conor Dooley <conor@xxxxxxxxxx> >> Sent: 2023年9月26日 21:26 >> To: Ming Qian <ming.qian@xxxxxxx> >> Cc: Mirela Rabulea (OSS) <mirela.rabulea@xxxxxxxxxxx>; >> robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; >> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; >> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; >> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; X.H. Bao >> <xiahong.bao@xxxxxxx>; Eagle Zhou <eagle.zhou@xxxxxxx>; Tao Jiang >> <tao.jiang_2@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; >> devicetree@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >> Subject: [EXT] Re: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: Assign slot for >> imx jpeg encoder/decoder >> >> Hi, >> >> On Tue, Sep 26, 2023 at 06:10:00PM +0800, Ming Qian wrote: >>> There are total 4 slots available in the IP, and we only need to use >>> one slot in one os, assign a single slot, configure interrupt and >>> power domain only for 1 slot, not for the all 4 slots. >>> >>> Signed-off-by: Ming Qian <ming.qian@xxxxxxx> >>> --- >>> v4 >>> - improve commit message >> >>> - don't make an ABI break >> >> What does this mean? Can you please try to explain things a bit more clearly >> in your changelogs? >> >> Also, where is the code that actually makes use of these properties? > > In v3 patch, I make this property required, make it an ABI break, so in v4, I remove it from required, and default to the previous behavior if it is missing. So say that you dropped line making the property required. > > The code patch is sent before, but the dts change is not applicable, so I send it separately. The code patch link is as below: > https://patchwork.linuxtv.org/project/linux-media/patch/cdadb4a23697fdc97def958c69b12cd00f547212.1685430841.git.ming.qian@xxxxxxx/ > > But in the patch, the property name is "slot", not "nxp,slot", I will make another patch to fix the property name after this patch is reviewed. Format your emails properly. It's difficult to read it. I already NAKed it, I will be NAKing still. Don't embed OS specific into the bindings nor into the DTS. Best regards, Krzysztof
