On 26/09/2023 11:28, Alain Volmat wrote:
> Introduction of the Galaxy Core GC2145 XVGA CMOS camera sensor.
>
> Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> ---
...
> +properties:
> + compatible:
> + const: galaxycore,gc2145
> +
> + reg:
> + enum:
> + - 0x3c
> +
> + clocks:
> + description: Reference to the xclk clock.
> + maxItems: 1
If xclk is the name of the pin and you want to mention it, then just:
items:
- description: xclk clock
(no "reference" or "GPIO descriptor" because it is redundant as Conor wrote)
> +
> + powerdown-gpios:
> + description: GPIO descriptor for the powerdown pin.
> + maxItems: 1
> +
> + reset-gpios:
> + description: GPIO descriptor for the reset pin.
> + maxItems: 1
> +
> + IOVDD-supply:
lowercase, so iovdd-supply. Same in other places.
> + description: Power Supply for I/O circuits (1.7 - 3V).
> +
> + AVDD-supply:
> + description: Power for analog circuit/sensor array (2.7 - 3V).
> +
> + DVDD-supply:
> + description: Power for digital core (1.7 - 1.9V).
> +
> + orientation: true
> +
> + rotation: true
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + required:
> + - endpoint
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - powerdown-gpios
> + - reset-gpios
> + - IOVDD-supply
> + - AVDD-supply
> + - DVDD-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c5 {
i2c
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gc2145@3c {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "galaxycore,gc2145";
> + reg = <0x3c>;
Best regards,
Krzysztof
