On Sun, Sep 24, 2023 at 01:53:25AM +0200, Stefan Wahren wrote: > Besides the IOCTL interface the VCHIQ character device also provides > a state dump of the whole VCHIQ driver via read. Moving the state dump > function to debugfs has a lot advantages: > > - following changes on state dump doesn't break userspace ABI > - debug doesn't depend on VCHIQ_CDEV > - dump code simplifies a lot and reduce the chance of buffer overflows > > Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx> > --- > > Hello, > > since recent discussion raised the question about the future of debugfs > for vchiq [1], i want to submit this cleanup patch as part of the > discussion. The patch itself based on the latest series [2] of > Umang Jain to convert VCHIQ into a bus. I'm aware of the checkpatch > warnings which will be fixed in the next version, but not revelant > to the discussion. Looks good to me, thanks for moving this to debugfs. greg k-h
