Re: [PATCH 03/57] media: i2c: hi846: Drop check for reentrant .s_stream()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Donnerstag, dem 14.09.2023 um 21:16 +0300 schrieb Laurent Pinchart:
> The subdev .s_stream() operation shall not be called to start
> streaming
> on an already started subdev, or stop streaming on a stopped subdev.
> Remove the check that guards against that condition.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/hi846.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c
> index fa0038749a3b..746e1f75f9d0 100644
> --- a/drivers/media/i2c/hi846.c
> +++ b/drivers/media/i2c/hi846.c
> @@ -1607,9 +1607,6 @@ static int hi846_set_stream(struct v4l2_subdev
> *sd, int enable)
>         struct i2c_client *client = v4l2_get_subdevdata(sd);
>         int ret = 0;
>  
> -       if (hi846->streaming == enable)
> -               return 0;
> -
>         mutex_lock(&hi846->mutex);
>  
>         if (enable) {


Tested-by: Martin Kepplinger <martink@xxxxxxxxx>

thanks Laurent,

                                 martin





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux