Hi Ricardo,
Thanks for the patch.
On Tue, Sep 19, 2023 at 04:01:23PM +0200, Ricardo Ribalda wrote:
> mipsel64el, ppc64el, ia64, ppc64, sparc64 and x32 have different lenghts
> for long long ints, which result in some compilation errors.
>
> Lets add some castings to help the compiler deal with this.
>
> We cannot use the Format macro constants ffrom inttypes because they
> seem to not be compatible with kernel (__u64 et al) types.
>
> Signed-off-by: Ricardo Ribalda <ricardo@xxxxxxxxxxx>
> ---
> yavta.c | 35 +++++++++++++++++++++--------------
> 1 file changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/yavta.c b/yavta.c
> index d562863..bf54e4f 100644
> --- a/yavta.c
> +++ b/yavta.c
> @@ -1313,7 +1313,8 @@ static void video_query_menu(struct device *dev,
> printf(" %u: %.32s%s\n", menu.index, menu.name,
> menu.index == value ? " (*)" : "");
> else
> - printf(" %u: %lld%s\n", menu.index, menu.value,
> + printf(" %u: %lld%s\n", menu.index,
Could you instead use PRId64 for this? You can avoid casting to another
type this way. Same for the other cases.
> + (long long)menu.value,
> menu.index == value ? " (*)" : "");
> };
> }
--
Regards,
Sakari Ailus
