Hi Laurent,
On Fri, Sep 15, 2023 at 12:19:16PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Fri, Sep 15, 2023 at 10:28:05AM +0300, Sakari Ailus wrote:
> > Initialise the try sink compose rectangle size to the sink compose
> > rectangle for binner and scaler sub-devices. This was missed due to the
> > faulty condition that lead to the compose rectangles to be initialised for
> > the pixel array sub-device where it is not relevant.
> >
> > Fixes: ccfc97bdb5ae ("[media] smiapp: Add driver")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> But you should instead use .init_cfg() and the subdev active state API.
> That can be done in a separate patch series.
Thank you for the review.
I have that patch still in the metadata series currently. If I can test it
in a timely manner for this set, I'll include it, too.
>
> > ---
> > drivers/media/i2c/ccs/ccs-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
> > index 49e0d9a09530..6f8fbd82e21c 100644
> > --- a/drivers/media/i2c/ccs/ccs-core.c
> > +++ b/drivers/media/i2c/ccs/ccs-core.c
> > @@ -3097,7 +3097,7 @@ static int ccs_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> > try_fmt->code = sensor->internal_csi_format->code;
> > try_fmt->field = V4L2_FIELD_NONE;
> >
> > - if (ssd != sensor->pixel_array)
> > + if (ssd == sensor->pixel_array)
> > continue;
> >
> > try_comp = v4l2_subdev_get_try_compose(sd, fh->state, i);
>
--
Regards,
Sakari Ailus
