Re: [PATCH] media: i2c: ov5693: Drop the unused streaming flag

[Dan Scally <dan.scally@xxxxxxxxxxxxxxxx>]

Hi Laurent - thanks for the patch

On 14/09/2023 18:45, Laurent Pinchart wrote:
> The streaming flag in the driver's private structure is set but never
> used. Drop it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>


Reviewed-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx>

> ---
>   drivers/media/i2c/ov5693.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index 488ee6d9d301..d6836725ced7 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -154,7 +154,6 @@ struct ov5693_device {
>   		unsigned int inc_y_odd;
>   		unsigned int vts;
>   	} mode;
> -	bool streaming;
>   
>   	struct v4l2_subdev sd;
>   	struct media_pad pad;
> @@ -996,8 +995,6 @@ static int ov5693_s_stream(struct v4l2_subdev *sd, int enable)
>   	if (ret)
>   		goto err_power_down;
>   
> -	ov5693->streaming = !!enable;
> -
>   	if (!enable)
>   		pm_runtime_put(ov5693->dev);
>   
>
> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
> prerequisite-patch-id: e46ede71d8cba61ae5bf7721eb35338b9e2d36d0
> prerequisite-patch-id: 4cfba8929058f17ab103d38ea1b447126e645935