On 06/09/2023 01:31, Paul Elder wrote:
> Add overlays for the Pumpkin i350 to support THP7312 cameras.
>
> Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 4 +
> .../mt8365-pumpkin-common-thp7312.dtsi | 23 ++++++
> .../mt8365-pumpkin-csi0-thp7312-imx258.dtso | 73 +++++++++++++++++++
> .../mt8365-pumpkin-csi1-thp7312-imx258.dtso | 73 +++++++++++++++++++
> 4 files changed, 173 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 20570bc40de8..ceaf24105001 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -56,4 +56,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
>
> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi0-thp7312-imx258.dtbo
> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi1-thp7312-imx258.dtbo
> mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo
> +
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mtk-mt8365-pumpkin.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi
> new file mode 100644
> index 000000000000..478697552617
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2023 Ideas on Board
> + * Author: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&{/} {
> + vsys_v4p2: regulator@0 {
Hm? Is this a bus?
> + compatible = "regulator-fixed";
> + regulator-name = "vsys-v4p2";
> + regulator-min-microvolt = <4200000>;
> + regulator-max-microvolt = <4200000>;
> + };
> +
> + camera61_clk: cam_clk24m {
And this is not on a bus? It's the same / node!
Please work on mainline, which means take mainline code and change it to
your needs. Do not take downstream poor code and change it...
No underscores in node names. Also generic node names, so at least with
generic prefix or suffix.
> + compatible = "fixed-clock";
> + clock-frequency = <24000000>;
> + #clock-cells = <0>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso
> new file mode 100644
> index 000000000000..740d14a19d75
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso
> @@ -0,0 +1,73 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2023 Ideas on Board
> + * Author: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/mt8365-pinfunc.h>
> +#include "mt8365-pumpkin-common-thp7312.dtsi"
> +
> +&i2c3 {
> + camera@61 {
> + compatible = "thine,thp7312";
> + reg = <0x61>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam0_pins_default>;
> + reset-gpios = <&pio 118 GPIO_ACTIVE_LOW>;
> + clocks = <&camera61_clk>;
> +
> + vddcore-supply = <&vsys_v4p2>;
> + vhtermrx-supply = <&vsys_v4p2>;
> + vddtx-supply = <&vsys_v4p2>;
> + vddhost-supply = <&vsys_v4p2>;
> + vddcmos-supply = <&vsys_v4p2>;
> + vddgpio_0-supply = <&vsys_v4p2>;
> + vddgpio_1-supply = <&vsys_v4p2>;
> + DOVDD-supply = <&vsys_v4p2>;
> + AVDD-supply = <&vsys_v4p2>;
> + DVDD-supply = <&vsys_v4p2>;
> +
> + orientation = <0>;
> + rotation = <0>;
> +
> + thine,rx,data-lanes = <4 1 3 2>;
NAK for this property.
> +
> + port {
> + isp1_out: endpoint {
> + remote-endpoint = <&seninf_in1>;
> + data-lanes = <4 2 1 3>;
> + };
> + };
> + };
> +};
> +
> +&pio {
> + cam0_pins_default: cam0_pins_default {
No underscores in node names.
> + pins_rst {
Ditto
Best regards,
Krzysztof
