On Wed, 06 Sep 2023 08:31:16 +0900, Paul Elder wrote: > Add bindings for the THine THP7312 ISP. > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > --- > Since the THP7312 supports multiple sensors, thine,rx-data-lanes alone > might not be enough. I was consdering using sensor nodes like what the > AP1302 does [1]. This way we can also move the power supplies that only > concern the sensor in there as well. I was wondering what to do about > the model name, though, as the thp7312 completely isolates that from the > rest of the system. > > I'm planning to add sensor nodes in somehow in a v2. > > [1] https://lore.kernel.org/linux-media/20211006113254.3470-2-anil.mamidala@xxxxxxxxxx/ > > .../bindings/media/thine,thp7312.yaml | 170 ++++++++++++++++++ > 1 file changed, 170 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/thine,thp7312.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/media/thine,thp7312.yaml:35:20: [error] syntax error: mapping values are not allowed here (syntax) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/media/thine,thp7312.example.dts' Documentation/devicetree/bindings/media/thine,thp7312.yaml:35:20: mapping values are not allowed here make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/media/thine,thp7312.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/media/thine,thp7312.yaml:35:20: mapping values are not allowed here /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/thine,thp7312.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230905233118.183140-2-paul.elder@xxxxxxxxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
