Hi Conor, thanks for the review. I've taken into account your comment and will push this into the v3. On Tue, Aug 29, 2023 at 04:00:06PM +0100, Conor Dooley wrote: > Hey, > > On Tue, Aug 29, 2023 at 03:23:45PM +0200, Alain Volmat wrote: > > Add the yaml binding for the DCMIPP driver. > > Please drop all mentions of drivers, bindings are for hardware. Ok > > > > > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx> > > --- > > .../bindings/media/st,stm32-dcmipp.yaml | 95 +++++++++++++++++++ > > 1 file changed, 95 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > > new file mode 100644 > > index 000000000000..63f03a1c42b6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > > @@ -0,0 +1,95 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/st,stm32-dcmipp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STM32 DCMIPP Digital Camera Memory Interface Pixel Processor binding > > s/binding// to appease the bot. Ok > > > + > > +maintainers: > > + - Hugues Fruchet <hugues.fruchet@xxxxxxxxxxx> > > + - Alain Volmat <alain.volmat@xxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: st,stm32mp13-dcmipp > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: kclk > > Can drop the items: here since you only have one. The name is also > pretty pointless when you only have one... Ok, I removed clock-names (from required as well). > > > + > > + resets: > > + maxItems: 1 > > + > > + port: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + DCMIPP supports a single port node with parallel bus. > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + bus-type: > > + enum: [5, 6] > > + default: 5 > > + > > + bus-width: > > + enum: [8, 10, 12, 14] > > + default: 8 > > + > > + pclk-sample: true > > + hsync-active: true > > + vsync-active: true > > + > > + required: > > + - pclk-sample > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/clock/stm32mp13-clks.h> > > + #include <dt-bindings/reset/stm32mp13-resets.h> > > + dcmipp: dcmipp@5a000000 { > > Neither of the labels here are used AFAICT, please remove them. Done Regards, Alain
