Hi Christophe,
Thank you for the patch.
On Sat, Aug 26, 2023 at 12:13:40AM +0200, Christophe JAILLET wrote:
> This is odd to have a of_node_put() just after a for_each_child_of_node()
> or a for_each_endpoint_of_node() loop. It should already be called
> during the last iteration.
>
> Remove these calls.
>
> Fixes: 66d8c9d2422d ("media: i2c: Add MAX9286 driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> /!\ This patch is speculative, review with case /!\
> ---
> drivers/media/i2c/max9286.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 20e7c7cf5eeb..f27a69b1b727 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1450,7 +1450,6 @@ static int max9286_parse_dt(struct max9286_priv *priv)
>
> i2c_mux_mask |= BIT(id);
> }
> - of_node_put(node);
> of_node_put(i2c_mux);
>
> /* Parse the endpoints */
> @@ -1514,7 +1513,6 @@ static int max9286_parse_dt(struct max9286_priv *priv)
> priv->source_mask |= BIT(ep.port);
> priv->nsources++;
> }
> - of_node_put(node);
>
> of_property_read_u32(dev->of_node, "maxim,bus-width", &priv->bus_width);
> switch (priv->bus_width) {
--
Regards,
Laurent Pinchart
