Re: [PATCH v2 3/3] media: ivsc: ace: probe ace device after init IPU bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wentong,

Thanks for the patch.

On Thu, Aug 24, 2023 at 11:21:02AM +0800, Wentong Wu wrote:
> Probe ivsc ace device after IPU bridge has been initialized.

This doesn't really match what the patch does: it puts csi_dev device if
the device doesn't have a fwnode. Could you provide a better commit
message please?

> 
> Signed-off-by: Wentong Wu <wentong.wu@xxxxxxxxx>
> ---
> v2:
>  - call put_device() if IPU bridge hasn't been initialized
> 
>  drivers/media/pci/intel/ivsc/mei_ace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/pci/intel/ivsc/mei_ace.c b/drivers/media/pci/intel/ivsc/mei_ace.c
> index 7879f1f..627ec40 100644
> --- a/drivers/media/pci/intel/ivsc/mei_ace.c
> +++ b/drivers/media/pci/intel/ivsc/mei_ace.c
> @@ -406,6 +406,9 @@ static int mei_ace_setup_dev_link(struct mei_ace *ace)
>  	if (!csi_dev) {
>  		ret = -EPROBE_DEFER;
>  		goto err;
> +	} else if (!dev_fwnode(csi_dev)) {
> +		ret = -EPROBE_DEFER;
> +		goto err_put;
>  	}
>  
>  	/* setup link between mei_ace and mei_csi */
> -- 
> 2.7.4
> 

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux