Re: [PATCH 1/1] media: v4l2-mc: Make v4l2_pipeline_pm_{get,put} deprecated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

Thank you for the patch.

On Wed, Aug 23, 2023 at 12:06:00PM +0300, Sakari Ailus wrote:
> The v4l2_pipeline_pm_get() and v4l2_pipeline_pm_put() functions were
> needed to control sub-devices' power states before runtime PM. These
> functions should no longer be used, and instead sub-device drivers should
> use runtime PM.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  include/media/v4l2-mc.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/media/v4l2-mc.h b/include/media/v4l2-mc.h
> index b39586dfba35..ed0a44b6eada 100644
> --- a/include/media/v4l2-mc.h
> +++ b/include/media/v4l2-mc.h
> @@ -143,6 +143,9 @@ int v4l2_create_fwnode_links(struct v4l2_subdev *src_sd,
>   * v4l2_pipeline_pm_get - Increase the use count of a pipeline
>   * @entity: The root entity of a pipeline
>   *
> + * THIS FUNCTION IS DEPRECATED. DO NOT USE IN NEW DRIVERS. USE RUNTIME PM
> + * ON SUB-DEVICE DRIVERS INSTEAD.
> + *
>   * Update the use count of all entities in the pipeline and power entities on.
>   *
>   * This function is intended to be called in video node open. It uses
> @@ -157,6 +160,9 @@ int v4l2_pipeline_pm_get(struct media_entity *entity);
>   * v4l2_pipeline_pm_put - Decrease the use count of a pipeline
>   * @entity: The root entity of a pipeline
>   *
> + * THIS FUNCTION IS DEPRECATED. DO NOT USE IN NEW DRIVERS. USE RUNTIME PM
> + * ON SUB-DEVICE DRIVERS INSTEAD.
> + *
>   * Update the use count of all entities in the pipeline and power entities off.
>   *
>   * This function is intended to be called in video node release. It uses

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux