On Mon, 21 Aug 2023 at 23:30, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> The exposure_max, exposure_def and hblank variables are only used in an
> inner scope in the imx219_set_pad_format() function. Move them to that
> scope to keep them closer to their usage and improve readability.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/imx219.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index e2f0d3782e7c..69908ebed04a 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -801,7 +801,6 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
> {
> struct imx219 *imx219 = to_imx219(sd);
> const struct imx219_mode *mode;
> - int exposure_max, exposure_def, hblank;
> struct v4l2_mbus_framefmt *format;
> struct v4l2_rect *crop;
> unsigned int bin;
> @@ -830,6 +829,10 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
> crop->top = (IMX219_NATIVE_HEIGHT - crop->height) / 2;
>
> if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
> + int exposure_max;
> + int exposure_def;
> + int hblank;
> +
> /* Update limits and set FPS to default */
> __v4l2_ctrl_modify_range(imx219->vblank, IMX219_VBLANK_MIN,
> IMX219_VTS_MAX - mode->height, 1,
> --
> Regards,
>
> Laurent Pinchart
>
