Re: [PATCH v2 02/18] media: i2c: imx219: Drop unused macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent

Thanks for the patch.

On Mon, 21 Aug 2023 at 23:29, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> Drop a handful of macros that are not used and don't provide any value.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>

> ---
>  drivers/media/i2c/imx219.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index c5aeec50b9e8..229dfe24304b 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -72,12 +72,6 @@
>
>  #define IMX219_VBLANK_MIN              4
>
> -/*Frame Length Line*/
> -#define IMX219_FLL_MIN                 0x08a6
> -#define IMX219_FLL_MAX                 0xffff
> -#define IMX219_FLL_STEP                        1
> -#define IMX219_FLL_DEFAULT             0x0c98
> -
>  /* HBLANK control - read only */
>  #define IMX219_PPL_DEFAULT             3448
>
> @@ -105,10 +99,6 @@
>  #define IMX219_TESTP_COLOUR_MIN                0
>  #define IMX219_TESTP_COLOUR_MAX                0x03ff
>  #define IMX219_TESTP_COLOUR_STEP       1
> -#define IMX219_TESTP_RED_DEFAULT       IMX219_TESTP_COLOUR_MAX
> -#define IMX219_TESTP_GREENR_DEFAULT    0
> -#define IMX219_TESTP_BLUE_DEFAULT      0
> -#define IMX219_TESTP_GREENB_DEFAULT    0
>
>  /* External clock frequency is 24.0M */
>  #define IMX219_XCLK_FREQ               24000000
> --
> Regards,
>
> Laurent Pinchart
>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux