Re: [PATCH v2 2/2] media: dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22/08/2023 11:28, Krzysztof Kozlowski wrote:
> On 22/08/2023 11:12, Sean Young wrote:
>> The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir
>> can be removed.
>>
>> Cc: Sicelo <absicsz@xxxxxxxxx>
>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
>> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx>
>> Cc: Pali Rohár <pali.rohar@xxxxxxxxx>
>> Cc: Pavel Machek <pavel@xxxxxx>
>> Cc: Timo Kokkonen <timo.t.kokkonen@xxxxxx>
>> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
>> Signed-off-by: Sean Young <sean@xxxxxxxx>
> 
> Unfortunately not much improved here, so:
> 1. Please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC. It might happen, that command when run on an
> older kernel, gives you outdated entries. Therefore please be sure you
> base your patches on recent Linux kernel.
> 
> You missed at least DT list (maybe more), so this won't be tested by
> automated tooling. Performing review on untested code might be a waste
> of time, thus I will skip this patch entirely till you follow the
> process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries.

Ykes, my bad, the DT list is there. Therefore you can expect Rob's bot
with complains.

> 
> 2. Test your bindings before sending. Especially if you decide to
> opt-out from automatic testing :/

Testing before sending is still needed, though.


Best regards,
Krzysztof




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux