Re: [PATCH 1/2] media: dt-bindings: nokia,n900-ir use generic pwm-ir-tx driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 21, 2023 at 01:56:56PM -0500, Rob Herring wrote:
> Please use get_maintainers.pl and send patches to the right place.
> Like the other DT maintainers and DT list...

Noted, my bad.

> On Mon, Aug 21, 2023 at 10:26 AM Sean Young <sean@xxxxxxxx> wrote:
> >
> > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir
> > can be removed.
> 
> How long has this been true? You are breaking users if they are on a
> version of OS where the pwm-ir-tx driver doesn't work (or didn't exist
> or wasn't enabled). I suspect this is a platform that will care about
> the ABI.
> 
> What you should do is make the "nokia,n900-ir" compatible work with
> the generic driver. Then old driver works still, the generic driver
> works on new OS versions, and the DTB doesn't change.

That makes a lot of sense. I'll re-roll.

Thanks for the feedback.

Sean



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux