Re: [PATCH] media: gc0310: Stop setting v4l2_subdev.fwnode to the endpoint fwnode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 12, 2023 at 4:36 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Endpoint matching is now handled by the v4l2-core and drivers no longer
> should set v4l2_subdev.fwnode to the endpoint fwnode.

...

>         dev->reset = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH);
>         if (IS_ERR(dev->reset)) {
> -               fwnode_handle_put(dev->ep_fwnode);
>                 return dev_err_probe(&client->dev, PTR_ERR(dev->reset),
>                                      "getting reset GPIO\n");
>         }

Now {} can be dropped.

...

>         dev->powerdown = devm_gpiod_get(&client->dev, "powerdown", GPIOD_OUT_HIGH);
>         if (IS_ERR(dev->powerdown)) {
> -               fwnode_handle_put(dev->ep_fwnode);
>                 return dev_err_probe(&client->dev, PTR_ERR(dev->powerdown),
>                                      "getting powerdown GPIO\n");
>         }

Ditto.

However, no strong opinion here as it is more style thingy. FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux