Hi Kate, On 8/2/23 11:55, Kate Hsuan wrote: > This batch of work removed all the #ifdef and made the driver able to > drive both ISP2400 and ISP2401. The changes include: > > 1. #ifdef were removed and the driver execution flow is determined in > runtime. > 2. ia_css_mipi_frame_enable_check_on_size() wasn't used so it also > removed. > 3. sh_css_config_input_network() for ISP2400 and ISP2401 was determined > in compiler time. This was also renamed to > sh_css_config_input_network_2400() and > sh_css_config_input_network_2401() for both types of atomisp. > 4. The atomisp type test at the begining of the driver was removed so > this driver can drive both types of atomisp. Thank you, all 12 patches look good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> for the series. And I have merged this into my hansg/media-atomisp branch now. Regards, Hans > Kate Hsuan (12): > media: atomisp: ia_css_raw.host: Remove #ifdef ISP2401 to make the > driver generic > media: atomisp: binary: Removed #ifdef ISP2401 to make driver generic > media: atomisp: hive_isp_css_include: Removed #ifdef ISP2401 to make > driver generic > media: atomisp: atomisp_compat_css20: Removed #ifdef ISP2401 to make > driver generic > media: atomisp: sh_css_mipi: Removed unused code > ia_css_mipi_frame_enable_check_on_size() > media: atomisp: sh_css: Removed #ifdef ISP2401 to make the driver > generic > media: atomisp: sh_css_sp: Remove #ifdef ISP2401 to make driver > generic > media: atomisp: sh_css: Removed #ifdef ISP2401 to make driver generic > media: atomisp: sh_css: Renamed sh_css_config_input_network() > media: atomisp: sh_css: Removed #ifdef ISP2401 to make code generic > media: atomisp: sh_css: Removed #ifdef ISP2401 to make the driver > generic > media: atomisp: atomisp_v4l2: Removed unnecessary code > > .../media/atomisp/pci/atomisp_compat_css20.c | 14 +- > .../staging/media/atomisp/pci/atomisp_v4l2.c | 19 -- > .../hive_isp_css_include/host/csi_rx_public.h | 2 - > .../host/pixelgen_public.h | 2 - > .../staging/media/atomisp/pci/ia_css_mipi.h | 16 -- > .../isp/kernels/raw/raw_1.0/ia_css_raw.host.c | 21 +- > .../atomisp/pci/runtime/binary/src/binary.c | 15 +- > drivers/staging/media/atomisp/pci/sh_css.c | 232 ++++++++---------- > .../staging/media/atomisp/pci/sh_css_mipi.c | 29 --- > drivers/staging/media/atomisp/pci/sh_css_sp.c | 60 ++--- > drivers/staging/media/atomisp/pci/sh_css_sp.h | 2 - > 11 files changed, 143 insertions(+), 269 deletions(-) >
