Re: [PATCH] v4l2-ctl: fix --silent option in manual

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

Sorry, I'm not taking this patch. It doesn't really add anything useful
and the text is also full of typos and grammatical errors.

The behavior of a --silent option is similar to how it is used in other
linux commands, so I don't think it needs any other explanation.

Regards,

	Hans

PS: for some reason you CC-ed linuxtv-commits@xxxxxxxxxxx, please don't
do that. linux-media is the right mailinglist for this.

On 8/10/23 13:46, Andrei Cherniaev wrote:
> silent option description not correct.
> ---
> utils/v4l2-ctl/v4l2-ctl.1.in | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/v4l2-ctl/v4l2-ctl.1.in b/utils/v4l2-ctl/v4l2-ctl.1.in
> index b8cbe6d2..107dd959 100644
> --- a/utils/v4l2-ctl/v4l2-ctl.1.in
> +++ b/utils/v4l2-ctl/v4l2-ctl.1.in
> @@ -140,7 +140,20 @@ Set the new access priority [VIDIOC_S_PRIORITY].
> \fI<prio>\fR is 1 (background), 2 (interactive) or 3 (record).
> .TP
> \fB--silent\fR
> -Only set the result code, do not print any messages.
> +
> +If operating system doesn't return error while v4l2-ctl try to read or 
> write any multimedia device parameter then --silent option is no matter.
> +If operating system return error while v4l2-ctl try to read or write 
> any multimedia device parameter then --silent option is important.
> +For example there isn't /dev/video1 in system.
> +If you don't use --silent option you will get both error message and 
> error result code
> +$ v4l2-ctl --device /dev/video1 --set-parm 25
> +VIDIOC_S_PARM: failed: Inappropriate ioctl for device
> +$ echo $? # get result code
> +255
> +
> +If you use --silent option you willn't get error message. But you still 
> can get error result code
> +$ v4l2-ctl --device /dev/video1 --set-parm 25 --silent
> +$ echo $? # get result code
> +255
> .TP
> \fB--sleep\fR \fI<secs>\fR
> Sleep \fI<secs>\fR, call QUERYCAP and close the file handle.
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux