On (23/04/26 17:29), Yunke Cao wrote: > Hi, > > This patch set implements UVC v1.5 region of interest using V4L2 > control API. I rebased v10 and resended. > > ROI control is consisted two uvc specific controls. > 1. A rectangle control with a newly added type V4L2_CTRL_TYPE_RECT. > 2. An auto control with type bitmask. > > V4L2_CTRL_WHICH_MIN/MAX_VAL is added to support the rectangle control. > > Tested on two different usb cameras using v4l2-compliance, v4l2-ctl > and calling ioctls. > > 1/11 adds V4L2_CTRL_TYPE_RECT. > 2/11, 3/11, 4/11 refactors uvc_ctrl.c. > 5/11 adds support for compound controls. > 6/11 is a cherry-pick for Hans' implementation of > V4L2_CTRL_WHICH_MIN/MAX_VAL in v4l2-core. > 7/11 documents min/max for the rectangle control. > 8/11 supports MIN/MAX in UVC. > 9/11 implements ROI in UVC. > 10/11 initializes ROI control to default value. > 11/11 documents the changes. Hello folks, Can we please get some reviews/feedback on this?