On 08/08/2023 12:20, Devarsh Thakkar wrote: >>>> +properties: >>>> + compatible: >>>> + const: img,e5010-jpeg-enc >>> >>> Your description suggests that this is part of TI SoC. Pretty often >>> licensed blocks cannot be used on their own and need some >>> customizations. Are you sure your block does not need any customization >>> thus no dedicated compatible is needed? >>> >> >> There is a wrapper for interfacing this core with TI SoC, I will recheck this >> interfacing but I believe nothing changes from programming perspective as >> there is 1-to-1 maintained between the clocks and signals w.r.t actual E5010 >> core. >> > > Just to add to above, on a second thought we think it would be better to > still have a separate compatible for TI as you suggested (since we have a > wrapper) so that it allows any customization needed for future. So compatible > enum would look like : > > oneOf: > - items: > - const: ti,e5010-jpeg-enc > - const: img,e5010-jpeg-enc > - const: img,e5010-jpeg-enc > > Thanks for the suggestion. Yeah, it's fine, assuming block can be used as img,e5010-jpeg-enc on its own. Best regards, Krzysztof
