Hi Laurent, On Mon, Aug 07, 2023 at 01:09:51PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Mon, Aug 07, 2023 at 10:40:59AM +0300, Sakari Ailus wrote: > > Improve the Kconfig help text to convey the ACE is for changing camera > > sensor ownership and CSI for configuring the CSI-2 rx and tx. > > > > Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > since v1: > > > > - Reworded most of the help text. > > > > drivers/media/pci/intel/ivsc/Kconfig | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig > > index 9535ac10f4f7..ec4ade92f583 100644 > > --- a/drivers/media/pci/intel/ivsc/Kconfig > > +++ b/drivers/media/pci/intel/ivsc/Kconfig > > @@ -7,6 +7,12 @@ config INTEL_VSC > > help > > This adds support for Intel Visual Sensing Controller (IVSC). > > > > - Enables the IVSC firmware services required for controlling > > - camera sensor ownership and CSI-2 link through Image Processing > > - Unit(IPU) driver of Intel. > > + The IVSC support is split into two devices, ACE (Algorithm > > + Context Engine) and CSI (Camera Serial Interface), each of which > > + have their own drivers. The ACE is used to select the ownership > > + of the sensor between the IVSC and the host CPU while the CSI is > > + used to both select the routing destination for the data the > > + sensor transmits over the CSI-2 bus between the IVSC and the > > + host CPU and to configure the CSI-2 bus itself. > > + > > + The modules will be called ivsc-ace and ivsc-csi. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Side question though: as those two modules are always used together, > could they be squashed into a single module ? It's uncommon to have multiple drivers in a single module. I'd keep them separate, even if you wouldn't use one without the other. -- Kind regards, Sakari Ailus
